fix: Fix codegen for is_method documentation #9950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bors d+ |
Contributor
|
✌️ yoshuawuyts can now approve this pull request. To approve and merge a pull request, simply reply with |
Previously the generated paths were invalid. This fixes that.
yoshuawuyts
force-pushed
the
fix-is_method-links-gen
branch
from
818485f to
586d6fc
Compare
Member
Author
|
bors r+ |
Contributor
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While authoring rust-lang/rust#88154 I realized that the codegen for the
enum_generate_is_methodassist currently generates invalid paths, and used snake case instead of spaces for the docs description. This fixes both issues. Thanks!