Skip to content

feat: Remove replace_unwrap_with_match in favor of inline_call #9498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Jul 5, 2021
Merged

feat: Remove replace_unwrap_with_match in favor of inline_call #9498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 0 additions & 186 deletions crates/ide_assists/src/handlers/replace_unwrap_with_match.rs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions crates/ide_assists/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ mod handlers {
mod replace_let_with_if_let;
mod replace_qualified_name_with_use;
mod replace_string_with_char;
mod replace_unwrap_with_match;
mod split_import;
mod toggle_ignore;
mod unmerge_use;
Expand Down Expand Up @@ -182,7 +181,6 @@ mod handlers {
replace_impl_trait_with_generic::replace_impl_trait_with_generic,
replace_let_with_if_let::replace_let_with_if_let,
replace_qualified_name_with_use::replace_qualified_name_with_use,
replace_unwrap_with_match::replace_unwrap_with_match,
split_import::split_import,
toggle_ignore::toggle_ignore,
unmerge_use::unmerge_use,
Expand Down
23 changes: 0 additions & 23 deletions crates/ide_assists/src/tests/generated.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,29 +1506,6 @@ fn main() {
)
}

#[test]
fn doctest_replace_unwrap_with_match() {
check_doc_test(
"replace_unwrap_with_match",
r#####"
//- minicore: result
fn main() {
let x: Result<i32, i32> = Ok(92);
let y = x.$0unwrap();
}
"#####,
r#####"
fn main() {
let x: Result<i32, i32> = Ok(92);
let y = match x {
Ok(it) => it,
$0_ => unreachable!(),
};
}
"#####,
)
}

#[test]
fn doctest_split_import() {
check_doc_test(
Expand Down