Skip to content

feat: Don't insert imports outside of cfg attributed items #9335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

feat: Don't insert imports outside of cfg attributed items #9335

merged 1 commit into from
Jun 18, 2021

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 18, 2021

Closes #6939

@Veykril
Copy link
Member Author

Veykril commented Jun 18, 2021

Tests for this live in the auto-import assist for now as I'll have to change up the insert_use tests a bit first. Will get to that tomorrow.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 18, 2021

Build succeeded:

@bors bors bot merged commit 0d3bad8 into rust-lang:master Jun 18, 2021
@Veykril Veykril deleted the attr-insert-use branch June 18, 2021 22:05
@matklad
Copy link
Contributor

matklad commented Aug 26, 2021

@Veykril could you create an issue (or a PR) to fix this for #[test] functions, who are implemitly #[cfg(test)] ?

@Veykril
Copy link
Member Author

Veykril commented Aug 26, 2021

Opened an issue #10040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imports inserted via Auto-import should inherit Cfg-Attributes
2 participants
@Veykril @matklad