Skip to content

Fully get rid of SyntaxNodePtr::range #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fully get rid of SyntaxNodePtr::range #4108

merged 1 commit into from
Apr 23, 2020

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Apr 23, 2020

bors r+
🤖

kjeremy
kjeremy reviewed Apr 23, 2020
View reviewed changes
crates/ra_syntax/src/ptr.rs
}
// pub fn range(&self) -> TextRange {
// self.range
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit 189ac4a into rust-lang:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kjeremy kjeremy kjeremy left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @kjeremy