Implement include macro #3494
Merged
Implement include macro #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Mar 6, 2020
| // FIXME: | ||
| // Handle include as expression | ||
| let node = | ||
| db.parse_or_expand(file_id.into()).ok_or_else(|| mbe::ExpandError::ConversionError)?; |
There was a problem hiding this comment.
Yeah, ideally, I think we should do something like parse_to_token_tree(db.file_text(file_id)). That is, it seems like we don't need to construct a syntax tree at this point at all.
There was a problem hiding this comment.
Yeah. It will be my next PR :)
Build succeeded |
21 tasks
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Automatic Rustup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement builtin
includemacro.env!("OUT_DIR")yet.