Add recursive macro support in original_range
#3314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
force-pushed
the
original-range-recursive
branch
from
71964bf to
42cd07e
Compare
edwin0cheng
force-pushed
the
original-range-recursive
branch
from
42cd07e to
ffdc740
Compare
|
Rebased. It is ready to review now ! |
|
bors r+ |
|
Bad day for bors today :( |
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
cargo update
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
cargo update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3135 and #3000
This PR should fix above issues (I tested), but let them open and ask for feedback if I missed something here.
PS: #3222 will moveoriginal_rangeto new Semantics API and thus this PR must be conflict with that. So please don't merge this now, I would rebase after that PR is merged.