Expand column!() #2355
Merged
Expand column!() #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @edwin0cheng |
|
Can we also have |
I think that deserves a separate PR. |
|
We also can't really have `file!()` at the moment, as rust-analyzer
(purposefully) lacks the knowledge about absolute file paths. I think, for
starters, we should expand file to just `""`.
…On Fri, 22 Nov 2019 at 16:57, Jeremy Kolb ***@***.***> wrote:
Can we also have file!()?
I think that deserves a separate PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2355>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M5IV74NSF5M7FBPX4LQU7QMHANCNFSM4JQQ5UQA>
.
|
|
I'll rebase this once #2357 merges. |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
2357: Expand file! to dummy "" r=edwin0cheng a=kjeremy See #2355 (comment) Co-authored-by: kjeremy <[email protected]>
kjeremy
force-pushed
the
column-builtin
branch
from
df8d25e to
1ee5592
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
2355: Expand column!() r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
Build succeeded
|
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.