Add support for stringify! builtin macro #2348
Conversation
pszpetkowski
changed the title
pszpetkowski
changed the title
| let macro_call = loc.ast_id.to_node(db); | ||
|
|
||
| let macro_content = { | ||
| let arg = macro_call.token_tree().ok_or_else(|| mbe::ExpandError::UnexpectedToken)?; |
There was a problem hiding this comment.
Might be a stupid question, but is this the same as _tt?
There was a problem hiding this comment.
There is no spacing information in _tt but I agree it is more accurate to use _tt directly here :
The builtin stringify! macro do not preserve space too.
There was a problem hiding this comment.
I think either solution is fine. It's also a shame that we can't easily add a test here, because there's no testing infra in hir_expand, but I think it makes sense to merge this without blocking on the said infra
| let macro_call = loc.ast_id.to_node(db); | ||
|
|
||
| let macro_content = { | ||
| let arg = macro_call.token_tree().ok_or_else(|| mbe::ExpandError::UnexpectedToken)?; |
There was a problem hiding this comment.
I think either solution is fine. It's also a shame that we can't easily add a test here, because there's no testing infra in hir_expand, but I think it makes sense to merge this without blocking on the said infra
2348: Add support for stringify! builtin macro r=matklad a=piotr-szpetkowski Refs #2212 First time ever contributing here, hopefully it's ok. 2352: Move TypeAlias to hir_def r=matklad a=matklad Co-authored-by: Piotr Szpetkowski <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
Canceled (will resume) |
2348: Add support for stringify! builtin macro r=matklad a=piotr-szpetkowski Refs #2212 First time ever contributing here, hopefully it's ok. 2352: Move TypeAlias to hir_def r=matklad a=matklad Co-authored-by: Piotr Szpetkowski <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
Build succeeded
|
Refs #2212
First time ever contributing here, hopefully it's ok.