More correct expand macro #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
commented
Nov 22, 2019
| // Replace the whole node if it is root | ||
| // `replace_descendants` will not replace the parent node | ||
| // but `SyntaxNode::descendants include itself | ||
| if expanded == *child.syntax() { |
There was a problem hiding this comment.
Or should we fix replace_descendants instead ?
There was a problem hiding this comment.
No, I think this is a better fix
matklad
reviewed
Nov 22, 2019
| // Replace the whole node if it is root | ||
| // `replace_descendants` will not replace the parent node | ||
| // but `SyntaxNode::descendants include itself | ||
| if expanded == *child.syntax() { |
There was a problem hiding this comment.
No, I think this is a better fix
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
2347: More correct expand macro r=matklad a=edwin0cheng Co-authored-by: Edwin Cheng <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.