Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Apr 14, 2025

Empirically this seems to make the resulting analysis-stats command ~20% faster.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2025
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Kobzol
Copy link
Member Author

Kobzol commented Apr 14, 2025

I haven't really tested this on CI (only locally), so maybe it would also be a good idea to test the release workflow using manual execution (workflow_dispatch) to test that it works properly (it can be done after merge, it cannot be tested on a PR from a fork, AFAIK).

@ofek
Copy link

ofek commented Apr 14, 2025

Does this not work on Windows?

Merged via the queue into rust-lang:master with commit 6c589ef Apr 14, 2025
14 checks passed
@FilipAndersson245
Copy link

I believe there should be nothing limiting the use of pgo on windows? but this only enables it for linux.

@ofek
Copy link

ofek commented Apr 14, 2025

Is there a reason why Windows was not enabled?

@Kobzol Kobzol deleted the ci-pgo branch April 14, 2025 15:13
@Kobzol
Copy link
Member Author

Kobzol commented Apr 14, 2025

PGO is IIRC quite broke on macOS, but on Windows it should be working fine. I just included one platform for testing right now, to see if/how it works on CI. We can definitely expand it to Windows if we see that it works (I'm not sure if the code I wrote in xdist --pgo will work on Windows, but hopefully it should - would be nice to try).

@Kobzol
Copy link
Member Author

Kobzol commented Apr 14, 2025

It doesn't seem to work with cargo zigbuild :( (https://github.com/rust-lang/rust-analyzer/actions/runs/14448767429/job/40515878851) I guess we should revert it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants