-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Distribute x64 and aarch64 Linux builds with PGO optimizations #19582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
I haven't really tested this on CI (only locally), so maybe it would also be a good idea to test the |
Does this not work on Windows? |
I believe there should be nothing limiting the use of pgo on windows? but this only enables it for linux. |
Is there a reason why Windows was not enabled? |
PGO is IIRC quite broke on macOS, but on Windows it should be working fine. I just included one platform for testing right now, to see if/how it works on CI. We can definitely expand it to Windows if we see that it works (I'm not sure if the code I wrote in |
It doesn't seem to work with |
Empirically this seems to make the resulting
analysis-stats
command ~20% faster.