feat: Add diagnostic fix to remove unnecessary wrapper in type mismatch #18458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Dec 7, 2024
|
☔ The latest upstream changes (presumably #18630) made this pull request unmergeable. Please resolve the merge conflicts. |
Giga-Bowser
force-pushed
the
master
branch
2 times, most recently
from
8b2dafa to
03a050a
Compare
I also reorganized the tests in a more logical order, and removed the redundant `test_` prefix from their names.
This caused a bug that was rather tricky to hunt down!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18383
I also reorganized some of the tests for the fix to add a missing
Ok()orSome()wrapper as they were somewhat scattered. The diff for this ended up looking messy but it's just moving functions around.