Skip to content

internal: Rewrite ImportMap::search_dependencies #16258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 4, 2024

Second attempt, this time with a lot of perf improvements

Fixes #16080
Fixes #16074
Fixes #15845

The main bottleneck for flyimport completions are now import path calculation and completion item rendering.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2024
@Veykril
Copy link
Member Author

Veykril commented Jan 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2024

📌 Commit 9b30521 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 4, 2024

⌛ Testing commit 9b30521 with merge e88788e...

@bors
Copy link
Contributor

bors commented Jan 4, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e88788e to master...

@bors bors merged commit e88788e into rust-lang:master Jan 4, 2024
@Veykril Veykril deleted the import-map-fix branch January 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
3 participants