Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[workspace]
members = ["xtask/", "lib/*", "crates/*"]
exclude = ["crates/proc-macro-srv/proc-macro-test/"]
exclude = ["crates/proc-macro-srv/proc-macro-test/imp"]
resolver = "2"

[workspace.package]
Expand Down Expand Up @@ -138,4 +138,4 @@ dashmap = { version = "=5.5.3", features = ["raw-api"] }
collapsible_if = "allow"
needless_pass_by_value = "allow"
nonminimal_bool = "allow"
redundant_pattern_matching = "allow"
redundant_pattern_matching = "allow"
9 changes: 1 addition & 8 deletions crates/hir/src/attrs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ pub fn resolve_doc_path_on(
link: &str,
ns: Option<Namespace>,
) -> Option<DocLinkDef> {
// AttrDefId::FieldId(it) => it.parent.resolver(db.upcast()),
// AttrDefId::EnumVariantId(it) => it.parent.resolver(db.upcast()),

resolve_doc_path_on_(db, link, def.attr_id(), ns)
}

Expand Down Expand Up @@ -267,14 +264,10 @@ fn resolve_impl_trait_item(
method_resolution::VisibleFromModule::None,
Some(name),
&mut |assoc_item_id| {
let assoc_item: AssocItem = assoc_item_id.into();

debug_assert_eq!(assoc_item.name(db).as_ref(), Some(name));

// If two traits in scope define the same item, Rustdoc links to no specific trait (for
// instance, given two methods `a`, Rustdoc simply links to `method.a` with no
// disambiguation) so we just pick the first one we find as well.
result = as_module_def_if_namespace_matches(assoc_item, ns);
result = as_module_def_if_namespace_matches(assoc_item_id.into(), ns);

if result.is_some() {
ControlFlow::Break(())
Expand Down
2 changes: 1 addition & 1 deletion crates/proc-macro-srv/proc-macro-test/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ doctest = false
cargo_metadata = "0.18.1"

# local deps
toolchain = { path = "../../toolchain", version = "0.0.0" }
toolchain.workspace = true

[features]
sysroot-abi = []