Skip to content

fix: generate delegate methods filters out functions that already exist on the struct's impls #14707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

fix: generate delegate methods filters out functions that already exist on the struct's impls #14707

merged 1 commit into from
May 2, 2023

Conversation

jhgg
Copy link
Contributor

@jhgg jhgg commented May 2, 2023

fixes #14703

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2023
@lnicola
Copy link
Member

lnicola commented May 2, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2023

📌 Commit a86c431 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 2, 2023

⌛ Testing commit a86c431 with merge 9c0c13e...

@bors
Copy link
Contributor

bors commented May 2, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 9c0c13e to master...

@bors bors merged commit 9c0c13e into rust-lang:master May 2, 2023
@jhgg jhgg deleted the fix/generate-delegate-method-filtering branch May 2, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate delegate methods should filter out functions that already exist on the struct
4 participants
@jhgg @lnicola @bors @rustbot