feat: Load proc-macros asynchronously #14405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
proc-macro-loading
branch
from
5e35334 to
e9fb2ff
Compare
Veykril
changed the title
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Mar 25, 2023
internal: Split out proc-macros from the CrateGraph cc #8646
|
💔 Test failed - checks-actions |
Veykril
changed the title
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Mar 25, 2023
feat: Load proc-macros asynchronously Closes #8646
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
matklad
reviewed
Mar 25, 2023
| @@ -1,5 +1,5 @@ | |||
| <!--- | |||
| lsp_ext.rs hash: 37f31ae648632897 | |||
| lsp_ext.rs hash: 92fe1037312754df | |||
There was a problem hiding this comment.
Might want to add a new command here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8646