fix: Type check unstable try{} blocks
#13856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
WaffleLapkin
commented
Dec 28, 2022
| // The ok-ish type that is expected from the last expression | ||
| let ok_ty = self.resolve_associated_type(try_ty.clone(), self.resolve_ops_try_ok()); | ||
|
|
||
| self.with_breakable_ctx(BreakableKind::Block, ok_ty.clone(), None, |this| { |
There was a problem hiding this comment.
I don't think that BreakableKind::Block is entirely correct, but as long as we do not check that Expr::Try is in a context where it can be used, this does not matter.
There was a problem hiding this comment.
Ye I imagine we'd need to add a new variant here once we check whether Expr::Try is in a correct context (we did for a week with an implementation I did, but that caused too many problems due to some things missing).
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11843