Skip to content

Conversation

jonas-schievink
Copy link
Contributor

We already did this if #![no_std] was present, this PR makes it work with #![cfg_attr(not(test), no_std)] too, which is very common in libraries.

Fixes #12035
cc #10718

@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Apr 20, 2022

📌 Commit dd4a921 has been approved by jonas-schievink

@bors
Copy link
Contributor

bors commented Apr 20, 2022

⌛ Testing commit dd4a921 with merge 3bda70a...

@bors
Copy link
Contributor

bors commented Apr 20, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 3bda70a to master...

@bors bors merged commit 3bda70a into rust-lang:master Apr 20, 2022
@jonas-schievink jonas-schievink deleted the prefer-core-cfg-attr-no-std branch April 20, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode: limit std suggestions outside tests when #![no_std] is conditional on #[cfg(test)]
2 participants