Skip to content

minor: Use compare_exchange_weak in limit::Limit::check #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

minor: Use compare_exchange_weak in limit::Limit::check #11367

merged 1 commit into from
Jan 28, 2022

Conversation

@WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Jan 28, 2022

Not a big deal, but generally loops should use _weak version of compare_exchange.

@lnicola
Copy link
Member

lnicola commented Jan 28, 2022

I'm not convinced that the eprintln! there is useful (we have more than one Limit), but sure, why not?

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 28, 2022

Build succeeded:

@bors bors bot merged commit 6634eaf into rust-lang:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaffleLapkin @lnicola