internal: improve compile times a bit #10066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2021
10066: internal: improve compile times a bit r=matklad a=matklad
I wanted to *quickly* remove `smol_str = {features = "serde"}`, and figured out that the simplest way to do that is to replace our straightforward proc macro serialization with something significantly more obscure.
Co-authored-by: Aleksey Kladov <[email protected]>
|
Build failed: |
* avoid arbitrary nested JSON tree (danger of stack overflow) * use more compact representation.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2021
10066: internal: improve compile times a bit r=matklad a=matklad
I wanted to *quickly* remove `smol_str = {features = "serde"}`, and figured out that the simplest way to do that is to replace our straightforward proc macro serialization with something significantly more obscure.
Co-authored-by: Aleksey Kladov <[email protected]>
|
Build failed: |
|
bors r+ |
lnicola
reviewed
Aug 29, 2021
| macro_name: Default::default(), | ||
| attributes: None, | ||
| lib: AbsPathBuf::assert(std::env::current_dir().unwrap()), | ||
| env: Default::default(), | ||
| }; | ||
|
|
||
| let json = serde_json::to_string(&task).unwrap(); | ||
| println!("{}", json); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to quickly remove
smol_str = {features = "serde"}, and figured out that the simplest way to do that is to replace our straightforward proc macro serialization with something significantly more obscure.