Skip to content

Don't log panics from proc macros #9859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matklad opened this issue Aug 11, 2021 · 0 comments · Fixed by #16037
Closed

Don't log panics from proc macros #9859

matklad opened this issue Aug 11, 2021 · 0 comments · Fixed by #16037
Labels
A-macro macro expansion

Comments

@matklad
Copy link
Member

matklad commented Aug 11, 2021

see https://users.rust-lang.org/t/reproducing-a-rust-analyzer-failure-in-the-terminal/63459/7?u=matklad

it seems that proc-macro used by a project panics, and those panics get printed to our stderr. I don't think we should do that, to not confuse them with real panics. Ideally, panic messge/trace should be stored as a String in macro exapnsion result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro macro expansion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants