Triggering "Add reference here" code action adds an ampersand in the wrong location.

[abusch]

This is basically the exact same symptom as #12717 except it happens when executing the "Add reference here" code action instead of using completion.

The same example as in #12717 can be used to reproduce it. If you type show_value(request.query_id) in the test function at the bottom of the file, then select "Add reference here", the ampersand character is added on line 6 instead of the correct line.

Interestingly, the "consider borrowing here" code action works fine.

rust-analyzer version: rust-analyzer 0.0.0 (75b2232 2022-07-03)

rustc version: rustc 1.62.0 (a8314ef7d 2022-06-27)

[Veykril]

Relevant code is here

rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs

Lines 57 to 77 in f1b257f

	fn add_reference(
	ctx: &DiagnosticsContext<'_>,
	d: &hir::TypeMismatch,
	acc: &mut Vec<Assist>,
	) -> Option<()> {
	let range = ctx.sema.diagnostics_display_range(d.expr.clone().map(|it| it.into())).range;
	let (_, mutability) = d.expected.as_reference()?;
	let actual_with_ref = Type::reference(&d.actual, mutability);
	if !actual_with_ref.could_coerce_to(ctx.sema.db, &d.expected) {
	return None;
	}
	let ampersands = format!("&{}", mutability.as_keyword_for_ref());
	let edit = TextEdit::insert(range.start(), ampersands);
	let source_change =
	SourceChange::from_text_edit(d.expr.file_id.original_file(ctx.sema.db), edit);
	acc.push(fix("add_reference_here", "Add reference here", source_change, range));
	Some(())
	}

[snprajwal]

I can't reproduce this, looks like it has been fixed by the patch for #12717?