Skip to content

Highlight unresolved derives as unresolvedReference #11350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Jan 26, 2022 · 2 comments · Fixed by #14284
Closed

Highlight unresolved derives as unresolvedReference #11350

Veykril opened this issue Jan 26, 2022 · 2 comments · Fixed by #14284
Labels
A-diagnostics diagnostics / error reporting A-highlighting (semantic) token highlighting C-feature Category: feature request

Comments

@Veykril
Copy link
Member

Veykril commented Jan 26, 2022

While we can't highlight tokens in random attributes as unresolvedReference due to them potentially not being reused in the macro expansion, we can do this for derive attributes specifically as it is a special builtin attribute anyways.
@Veykril Veykril added A-diagnostics diagnostics / error reporting C-feature Category: feature request A-highlighting (semantic) token highlighting labels Jan 26, 2022
@TheDoctor314

This comment was marked as outdated.

Sign in to view
@Veykril

This comment was marked as outdated.

Sign in to view
@Veykril Veykril changed the title Highlight and diagnose unresolved derives as unresolvedReference Highlight unresolved derives as unresolvedReference Mar 5, 2023
@Veykril Veykril mentioned this issue Mar 8, 2023
Merged
@bors bors closed this as completed in c951093 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics diagnostics / error reporting A-highlighting (semantic) token highlighting C-feature Category: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Highlight unresolved derives as being unresolved Veykril/rust-analyzer
2 participants
@Veykril @TheDoctor314