This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Ensure that --error-format is only passed once to rustc
#1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update RLS Merged PRs: * fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486) - Retain `RUST_LOG` in `rls --cli` mode * Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497) - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config) * Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500) - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇♂️ )
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update RLS Merged PRs: * fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486) - Retain `RUST_LOG` in `rls --cli` mode * Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497) - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config) * Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500) - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇♂️ )
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update RLS Merged PRs: * fix(cmd): make clear_env_rust_log default to false (rust-lang/rls#1486) - Retain `RUST_LOG` in `rls --cli` mode * Pass --file-lines to rustfmt only if specified (rust-lang/rls#1497) - Fix entire-file formatting when using external rustfmt (specified via `rustfmt_path` config) * Ensure that --error-format is only passed once to `rustc` (rust-lang/rls#1500) - Unbreaks RLS when used together with Cargo [pipelining build](rust-lang#60988) feature (@alexcrichton I'd consider this a stabilization blocker, mind adding it to the tracking issue for the record? 🙇♂️ )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1471, this builds on it by also filtering the
--FLAG VALUEarguments and adding unit tests.Closes #1471.