-
Notifications
You must be signed in to change notification settings - Fork 563
Reflect explicit macro import in reference #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reflect explicit macro import in reference #2077
Conversation
This comment has been minimized.
This comment has been minimized.
1e9df55 to
afed4f6
Compare
|
I've updated the PR, it's not clear to me what changes are still desired please re-review. |
|
Can you rebase on latest master now that #1913 has been merged? I would suggest the following edits: diff --git a/src/names/preludes.md b/src/names/preludes.md
index 3a2c3ff1..b25b4b8a 100644
--- a/src/names/preludes.md
+++ b/src/names/preludes.md
@@ -81,7 +81,7 @@ r[names.preludes.extern.no_std]
### The `no_std` attribute
r[names.preludes.extern.no_std.intro]
-The *`no_std` [attribute][attributes]* causes the [`std`] crate to not be linked automatically, the [standard library prelude] to instead use the `core` prelude, and the [`macro_use` prelude] to instead use the macros exported from the `core` crate.
+The *`no_std` [attribute][attributes]* causes the [`std`] crate to not be linked automatically and the [standard library prelude] to instead use the `core` prelude.
> [!EXAMPLE]
> <!-- ignore: test infrastructure can't handle no_std -->
@@ -110,9 +110,6 @@ The `no_std` attribute may be used any number of times on a form.
r[names.preludes.extern.no_std.module]
The `no_std` attribute changes the [standard library prelude] to use the `core` prelude instead of the `std` prelude.
-r[names.preludes.extern.no_std.macro_use]
-By default, all macros exported from the `std` crate are added to the [`macro_use` prelude]. If the `no_std` attribute is specified, then all macros exported from the `core` crate are placed into the [`macro_use` prelude] instead.
-
r[names.preludes.extern.no_std.edition2018]
> [!EDITION-2018]
> Before the 2018 edition, `std` is injected into the crate root by default. If `no_std` is specified, `core` is injected instead. Starting with the 2018 edition, regardless of `no_std` being specified, neither is injected into the crate root. |
afed4f6 to
6e5f0ec
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
My bad, I had forgotten to track upstream. First PR in this repo. |
|
I've applied your feedback and added a section to name-resolution.md |
6e5f0ec to
3eb47c5
Compare
3eb47c5 to
60b5203
Compare
Companion PR for rust-lang/rust#139493