Update cold and inline to use the attribute template
#1907
Merged
+138
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
I didn't feel like this section was pulling its weight. It also wasn't entirely correct.
This adds some wording that was removed from the "optimization hints" section.
This rule did not seem to be covered elsewhere. I'm not 100% positive this is the best way to document this, but I think it is accurate. This is implemented in https://github.com/rust-lang/rust/blob/5526a2f47cd676ceeedc08cf71ae75ce2e9284ae/compiler/rustc_passes/src/check_attr.rs#L482-L497
traviscross
force-pushed
the
cold-inline
branch
from
9173d09 to
9d865bf
Compare
Note in particular that `inline` and similar attributes can be applied to `async` blocks as well as to closures. Along with the editorial revisions, let's say that and also discuss the current limitations that affect how these can be applied.
On lang, we had earlier made a decision about how `inline` should apply to `async fn`. Let's document that here.
traviscross
force-pushed
the
cold-inline
branch
from
9d865bf to
80afb2e
Compare
traviscross
approved these changes
Sep 3, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.codegen.inline.syntaxattributes.codegen.inline.allowed-positionsattributes.codegen.inline.duplicatesattributes.codegen.inline.traitattributes.codegen.inline.externally-exportedattributes.codegen.cold.introattributes.codegen.cold.syntaxattributes.codegen.cold.allowed-positionsattributes.codegen.cold.duplicatesattributes.codegen.cold.traitRemoved rules:
attributes.codegen.hintattributes.codegen.hint.cold-inlineattributes.codegen.hint.usage--- split into the corresponding attributes