Skip to content

Add issue templates #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add issue templates #58

merged 1 commit into from
Feb 3, 2021

Conversation

workingjubilee
Copy link
Member

The main purpose of these is to offer rerouting where rerouting is appropriate. Mostly derived from existing examples in https://github.com/rust-lang/rust.

Closes #24.

@thomcc
Copy link
Member

thomcc commented Jan 28, 2021

I think you should add one for "blank issue" the way rustc has https://github.com/rust-lang/rust/blob/master/.github/ISSUE_TEMPLATE/blank_issue.md, since otherwise I tend to find people get discouraged if their issue doesn't fit one of the provided templates.

@workingjubilee
Copy link
Member Author

workingjubilee commented Jan 28, 2021 via email

@thomcc
Copy link
Member

thomcc commented Jan 28, 2021

Ah, sorry, I'm not sure. I guess we can followup with a patch if it turns out it is needed.

about: Please direct issues about Rust's support for intrinsics to core::arch
- name: Internal Compiler Error
url: https://github.com/rust-lang/rust/issues
about: Please report ICEs to the rustc repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICEs may also be relevant here? If anyone is going to fix a stdsimd related ICE, it's probably us.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the compiler CLI already points ICEs back to the rust-lang/rust repo maybe we should keep that and help out over there as they come up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ICEs are pretty much by definition issues with the compiler. We should obviously fix anything that primarily is an issue for SIMD-related code, though.

@workingjubilee
Copy link
Member Author

Let me know if this looks good so I can squash these commits!

The main purpose of these is to offer rerouting where rerouting is
appropriate. Mostly derived from existing examples in rust-lang/rust.
@workingjubilee workingjubilee merged commit 9b6b5d7 into master Feb 3, 2021
@workingjubilee
Copy link
Member Author

@thomcc was right, and I was wrong!

@workingjubilee
Copy link
Member Author

...correction, I was right, however,
image
That is pretty tiny text for "blank issue" at the bottom of the listing. That is... curious, almost passive-aggressive?

@workingjubilee workingjubilee deleted the issue-templates branch February 9, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve contributor docs to minimum
5 participants