-
Notifications
You must be signed in to change notification settings - Fork 92
Add issue templates #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think you should add one for "blank issue" the way rustc has https://github.com/rust-lang/rust/blob/master/.github/ISSUE_TEMPLATE/blank_issue.md, since otherwise I tend to find people get discouraged if their issue doesn't fit one of the provided templates. |
I was pretty sure that was what `blank_issues_enabled: true` did, without
requiring an additional file. I am happy to add one if necessary, however.
|
Ah, sorry, I'm not sure. I guess we can followup with a patch if it turns out it is needed. |
about: Please direct issues about Rust's support for intrinsics to core::arch | ||
- name: Internal Compiler Error | ||
url: https://github.com/rust-lang/rust/issues | ||
about: Please report ICEs to the rustc repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICEs may also be relevant here? If anyone is going to fix a stdsimd related ICE, it's probably us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the compiler CLI already points ICEs back to the rust-lang/rust
repo maybe we should keep that and help out over there as they come up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, ICEs are pretty much by definition issues with the compiler. We should obviously fix anything that primarily is an issue for SIMD-related code, though.
Let me know if this looks good so I can squash these commits! |
The main purpose of these is to offer rerouting where rerouting is appropriate. Mostly derived from existing examples in rust-lang/rust.
917663f
to
e4cdd15
Compare
@thomcc was right, and I was wrong! |
The main purpose of these is to offer rerouting where rerouting is appropriate. Mostly derived from existing examples in https://github.com/rust-lang/rust.
Closes #24.