Skip to content

Combine LanesAtMost32 and SimdArray into a single trait "Vector" #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2021
Merged

Combine LanesAtMost32 and SimdArray into a single trait "Vector" #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c077bf3
Rename SimdArray to Vector, remove its generic parameter, and remove …
calebzulawski Jun 25, 2021
f178dda
Add as_slice/as_mut_slice to Vector
calebzulawski Jun 27, 2021
fdd7d6e
Change as_slice to as_array
calebzulawski Jun 28, 2021
529ffe0
Use new module naming
calebzulawski Jun 29, 2021
f93bef3
Move vector implementation
calebzulawski Jun 29, 2021
97c25dd
Add lane count marker type
calebzulawski Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
253 changes: 0 additions & 253 deletions crates/core_simd/src/array.rs
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions crates/core_simd/src/comparisons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
use crate::LanesAtMost32;
use crate::{LaneCount, SupportedLaneCount};

macro_rules! implement_mask_ops {
{ $($vector:ident => $mask:ident ($inner_ty:ident),)* } => {
$(
impl<const LANES: usize> crate::$vector<LANES>
where
crate::$vector<LANES>: LanesAtMost32,
crate::$inner_ty<LANES>: LanesAtMost32,
crate::$mask<LANES>: crate::Mask,
LaneCount<LANES>: SupportedLaneCount,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this kind of thing is a huge improvement! And hopefully will make some other simplifications easier.

{
/// Test if each lane is equal to the corresponding lane in `other`.
#[inline]
Expand Down
124 changes: 0 additions & 124 deletions crates/core_simd/src/first.rs
View file
Open in desktop

This file was deleted.

Loading