Combine LanesAtMost32 and SimdArray into a single trait "Vector" #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
requested changes
Jun 29, 2021
calebzulawski
force-pushed
the
feature/traits
branch
from
3ba0687 to
97c25dd
Compare
workingjubilee
approved these changes
Jul 24, 2021
| crate::$vector<LANES>: LanesAtMost32, | ||
| crate::$inner_ty<LANES>: LanesAtMost32, | ||
| crate::$mask<LANES>: crate::Mask, | ||
| LaneCount<LANES>: SupportedLaneCount, |
There was a problem hiding this comment.
Well, this kind of thing is a huge improvement! And hopefully will make some other simplifications easier.
Comment on lines
+35
to
+36
| mod lane_count; | ||
| pub use lane_count::*; |
There was a problem hiding this comment.
Return of LanesAtMost: General Trait Bound's Revenge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix some unresolved questions in #139 regarding
SimdArrayhaving a generic parameter.In particular, this made it not appropriate for replacing
LanesAtMost32. Additionally, it made it impossible to use in a context where you otherwise don't know the lane count, e.g.impl Vector.An unfortunate side effect of this change is that scatter/gather no longer work in the trait (nor does anything else that references the lane count in a type. This requires the super-unstable
const_evaluatable_checkedfeature).I also threw in the change from
as_slicetoas_arrayas discussed in zulip, and fixes #51.