Skip to content

Prevent silently falling back to dynamic linking when static linking is explicitly requested #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent silently falling back to dynamic linking when static linking is explicitly requested #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5a4101
Moved the system lib check not to prevent taking the static linking b…
golddranks Mar 1, 2017
cd7c3b1
Fixed idents
golddranks Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,18 +430,25 @@ impl Library {
}
"-l" => {
self.libs.push(val.to_string());
if statik && !is_system(val, &dirs) {
let meta = format!("rustc-link-lib=static={}", val);
config.print_metadata(&meta);
} else {
let meta = format!("rustc-link-lib={}", val);
config.print_metadata(&meta);
}
}
_ => {}
}
}

for val in &self.libs {
if statik {
if is_system(val, &dirs) {
panic!("The library \"{}\" is a system library, \
which means it can't be linked statically!", val);
}
let meta = format!("rustc-link-lib=static={}", val);
config.print_metadata(&meta);
} else {
let meta = format!("rustc-link-lib={}", val);
config.print_metadata(&meta);
}
}

let mut iter = output.trim_right().split(' ');
while let Some(part) = iter.next() {
if part != "-framework" {
Expand Down