native-lib: bump libffi #4634
Merged
native-lib: bump libffi #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! |
Member
|
That was very quick, thanks :) |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 7, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - #147581 - rust-lang/miri#4634 - #147744 Closes #147556.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - #4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
github-actions bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Nov 10, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - rust-lang/miri#4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Nov 10, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - rust-lang/miri#4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Nov 10, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - rust-lang/miri#4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang#147581 - rust-lang/miri#4634 - rust-lang#147744 Closes rust-lang#147556.
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Nov 16, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - rust-lang/miri#4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 19, 2025
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang/rust#147581 - rust-lang/miri#4634 - rust-lang/rust#147744 Closes rust-lang/rust#147556.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4633
The actual breaking change in libffi 5.0 seems to be the lifetime on the
libffi::middle::Argtype, which we were already more-or-less respecting the semantics of. This lets us simplify the code that handles it so hooray!