Avoid error patterns matching themselves #2158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I just realized the same thing. 😂 an error annotation justifying itself is such a great bug. :D |
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
|
☔ The latest upstream changes (presumably #2157) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 25, 2022
RalfJung
reviewed
May 28, 2022
|
LGTM! r=me with the last nit resolved (by adding a comment explaining the lack of CARGO_BUILD_FLAGS, or adding them) and the commits squashed a bit (or entirely). |
|
@bors r+ |
|
📌 Commit 3832227 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2156
fixes #2155
this will be obsolete the moment I extract that data from json diagnostics instead of just regexing the stderr.