-
Notifications
You must be signed in to change notification settings - Fork 394
Add shim for libc::sysconf(libc::_SC_NPROCESSORS_CONF) #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! We should find some way to test this. What target triple would be suited to trigger this code path in |
Looks like you are on Line 50 in 6fdda8a
|
@RalfJung should i change that line, or add a new line? |
Changing it is okay I think, we don't need to test that same target tripled on all host platforms. |
Done in 36ce776 |
I see the test failures, and I don't think I have the time to address all of them. Can an issue be opened and this be done in a separate pull request? |
Looks like some more work is needed to support aarch64, yeah. I should have time today or tomorrow to look into that and will push to this PR, if you don't mind. |
Yeah sounds good to me. Thanks so much 🙇🏻 |
@bors r+ |
📌 Commit 7d8f8c4 has been approved by |
☀️ Test successful - checks-actions |
libc::sysconf(libc::_SC_NPROCESSORS_CONF)
is used by AArch64 devices to get the number of CPUs in thenum_cpus
crate:https://github.com/seanmonstar/num_cpus/blob/b423db0a698b035914ae1fd6b7ce5d2a4e727b46/src/lib.rs#L337-L342