Add support for reading aggregated query cache hit counts #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Jul 4, 2025
| // Aggregated query cache hit counts | ||
| QUERY_CACHE_HIT_COUNT_EVENT_KIND => { | ||
| record_event_data(¤t_event.label, &|data| { | ||
| data.number_of_cache_hits = value as usize; |
There was a problem hiding this comment.
should we assert that it was zero before?
There was a problem hiding this comment.
Good point. All the cache counts should be at the end, and we read in .rev() order, but it would be better to check. That being said, the aggregated and per-query-invocation counters should be the same; if not, something is very wrong.. 😆 Added an assert.
oli-obk
approved these changes
Jul 4, 2025
|
It's through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the analysis module for aggregated query cache hit counts, which were added to rustc in rust-lang/rust#142978. I tried to keep compatibility with the original (very expensive) per-query-invocation cache hit counters.