Skip to content

Fix even more print page links. #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix even more print page links. #963

merged 1 commit into from
Jul 1, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 21, 2019

This fixes two more style of links in the print.html page:

  • A bare fragment link #foo would link to the wrong location if it was inside a directory.
  • Inline HTML links weren't fixed at all. This only addresses <a> and <img> tags, and uses a gumby approach to parsing, but should work well enough in most cases.

@Dylan-DPC-zz Dylan-DPC-zz merged commit 228e99b into rust-lang:master Jul 1, 2019
@ehuss ehuss mentioned this pull request Jul 7, 2019
Closed
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@ehuss @Dylan-DPC
Fix even more print page links. (rust-lang#963)
7dab51e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehuss @Dylan-DPC-zz