Fix color for rustdoc error messages #2981
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in tracing-subscriber where it escapes ANSI codes, the output from rustdoc was changed to be escaped instead of colored. This fixes the issue by just printing to the console directly. This does not have a test because it is difficult to emulate a terminal in the testsuite, and I don't feel like adding color overrides at the moment. Ref: - rust-lang#2829 -- Switched to tracing - GHSA-xwfj-jgwm-7wp5 -- CVE-2025-58160 - tokio-rs/tracing#3378 -- Discussion of supporting color codes. Eventually mdbook's primary output should migrate away from using log messages, and instead use a structured console system. However, that's a ways off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in tracing-subscriber where it escapes ANSI codes, the output from rustdoc was changed to be escaped instead of colored. This fixes the issue by just printing to the console directly.
This does not have a test because it is difficult to emulate a terminal in the testsuite, and I don't feel like adding color overrides at the moment.
Ref:
Eventually mdbook's primary output should migrate away from using log messages, and instead use a structured console system. However, that's a ways off.