[msan] Fix bugs when instrumenting x86.avx512*_cvt* intrinsics #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalar intrinsics x86.avx512*_cvt* have an extra rounding mode operand. We can directly ignore it to reuse the SSE/AVX math. This fix the bug https://bugs.llvm.org/show_bug.cgi?id=48298. Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D92206
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Dec 9, 2020
Update LLVM submodule * [[msan] Fix bugs when instrumenting x86.avx512*_cvt* intrinsics](rust-lang/llvm-project#84) * [[X86][AVX512] Only lower to VPALIGNR if we have BWI (PR48322)](rust-lang/llvm-project#85)
vext01
added a commit
to vext01/llvm-project
that referenced
this pull request
Oct 3, 2023
84: Improve unimplemented stuff and serialise instruction types. r=ltratt a=vext01 Co-authored-by: Edd Barrett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick https://reviews.llvm.org/D92206
This addresses rust-lang/stdarch#957 (for
_mm_cvt_roundss_u32but not for_mm512_shuffle_ps).A test is at rust-lang/rust#79382.
This can also be tested with an unpatched rustc, with the following command: