This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Switch repository layout to use a virtual manifest #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
virtual-manifest
branch
5 times, most recently
from
a9b32a3 to
0862b08
Compare
tgross35
changed the title
tgross35
force-pushed
the
virtual-manifest
branch
from
0862b08 to
af42a05
Compare
tgross35
force-pushed
the
virtual-manifest
branch
from
af42a05 to
2fa1e0d
Compare
tgross35
force-pushed
the
virtual-manifest
branch
11 times, most recently
from
7ff034f to
3b6fc3a
Compare
tgross35
force-pushed
the
virtual-manifest
branch
2 times, most recently
from
f06b2b3 to
b40013e
Compare
tgross35
added a commit
to tgross35/rust-libm
that referenced
this pull request
Apr 18, 2025
Benchmarks for [1] seemed to indicate that repository organization for some reason had an effect on performance, even though the exact same rustc commands were running (though some with a different order). After investigating more, it appears that dependencies may have an affect on inlining thresholds for generic functions. It is surprising that this happens, we more or less expect that public functions will be standalone but everything they call will be inlined. To help ensure this, mark all generic functions `#[inline]` if they should be merged into the public function. Zulip discussion at [2]. [1]: rust-lang#533 [2]: https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Dependencies.20affecting.20codegen/with/513079387
tgross35
added a commit
that referenced
this pull request
Apr 18, 2025
Benchmarks for [1] seemed to indicate that repository organization for some reason had an effect on performance, even though the exact same rustc commands were running (though some with a different order). After investigating more, it appears that dependencies may have an affect on inlining thresholds for generic functions. It is surprising that this happens, we more or less expect that public functions will be standalone but everything they call will be inlined. To help ensure this, mark all generic functions `#[inline]` if they should be merged into the public function. Zulip discussion at [2]. [1]: #533 [2]: https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Dependencies.20affecting.20codegen/with/513079387
tgross35
force-pushed
the
virtual-manifest
branch
2 times, most recently
from
18b79bb to
c7d18c4
Compare
|
This was originally showing a regression for fmaf128: Plus a number of small improvements. From zulip discussions at #general > Rust application 60% slower when built with Bazel and https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Dependencies.20affecting.20codegen/with/513078956, it seems like that may have come from differences in inlining. #545 should make things more consistent. |
In preparation for switching to a virtual manifest, move the `libm` crate into a subdirectory and update paths to match. Updating `Cargo.toml` is done in the next commit so git tracks the moved file correctly.
Move the workspace configuration to a virtual manifest. This reorganization makes a more clear separation between package contents and support files that don't get distributed. It will also make it easier to merge this repository with `compiler-builtins` which is planned (builtins had a similar update done in [1]). LICENSE.txt and README.md are symlinkedinto the new directory to ensure they get included in the package. [1]: rust-lang/compiler-builtins#702
tgross35
force-pushed
the
virtual-manifest
branch
from
c7d18c4 to
84f0f3f
Compare
tgross35
added a commit
that referenced
this pull request
Apr 18, 2025
Benchmarks for [1] seemed to indicate that repository organization for some reason had an effect on performance, even though the exact same rustc commands were running (though some with a different order). After investigating more, it appears that dependencies may have an affect on inlining thresholds for generic functions. It is surprising that this happens, we more or less expect that public functions will be standalone but everything they call will be inlined. To help ensure this, mark all generic functions `#[inline]` if they should be merged into the public function. Zulip discussion at [2]. [1]: #533 [2]: https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Dependencies.20affecting.20codegen/with/513079387
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the workspace configuration to a virtual manifest. This
reorganization makes a more clear separation between package contents
and support files that don't get distributed. It will also make it
easier to merge this repository with
compiler-builtinsif that is doneat some point, which had a similar update done in 1.
LICENSE.txt and README.md are symlinked into the new directory to ensure
they get included in the package.
ci: skip-extensive