Fix makedev function signature on Apple targets

[nohajc]

Description

Fix the makedev function signature according to actual implementation:
https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57b9f54c2f6d4a15585/bsd/sys/types.h#L154
https://developer.apple.com/documentation/kernel/1547212-makedev

Issue: #4360

Checklist

• Relevant tests in libc-test/semver have been updated
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI

[rustbot]

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[tgross35]

This lgtm, but any reason not to also fix major and minor?

[nohajc]

@tgross35 Oh, right. They're not even using dev_t there. Let me fix it. It's so bizarre...

[nohajc]

Well, I just noticed the functions are only compiled for C++. C still uses those macros which are more loosely defined. Not sure that's reason enough to deviate from the type signatures even if they're questionable.

[tgross35]

Going through old PRs, sorry I missed this one. I think this change is worth making even if they use untyped macros, given this makes Apple match all the other platforms. We still can't backport unfortunately due to breakage, but this would be good to have for 1.0.

Would you be able to rebase?

[nohajc]

Would you be able to rebase?

Done. :)

[tgross35]

LGTM, thank you! I think you may need to rebase so CI actually passes

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.