Skip to content

hermit: add/fix AF_* values #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025
Merged

hermit: add/fix AF_* values #4344

merged 3 commits into from
Mar 22, 2025

Conversation

mkroening
Copy link
Contributor

Description

This PR

  • adds AF_UNSPEC,
  • adds AF_VSOCK, and
  • makes AF_INET = 3

on Hermit.

Sources

See hermit-os/kernel/src/syscalls/socket.rs#L27-L31 for reference and hermit-os/kernel#1640 for details on the AF_INET change (POSIX requires AF_UNSPEC = 0 and distinct values for AF_*).

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
Merged via the queue into rust-lang:main with commit ad43e8e Mar 22, 2025
41 of 43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
(backport <rust-lang#4344>)
(cherry picked from commit d6ccb3d)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
(backport <rust-lang#4344>)
(cherry picked from commit 248734e)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
(backport <rust-lang#4344>)
(cherry picked from commit 13ac7db)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 9, 2025
…-Simulacrum

Update hermit-abi to 0.5.1

This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.
Zalathar added a commit to Zalathar/rust that referenced this pull request May 10, 2025
…-Simulacrum

Update hermit-abi to 0.5.1

This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2025
…-Simulacrum

Update hermit-abi to 0.5.1

This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2025
…-Simulacrum

Update hermit-abi to 0.5.1

This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup merge of rust-lang#140789 - hermit-os:hermit-abi-0.5.1, r=Mark-Simulacrum

Update hermit-abi to 0.5.1

This updates hermit-abi to version 0.5.1, bringing the [recent `AF_*`](rust-lang/libc#4344) changes to std.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants