Skip to content

Replace arch-conditional c_char with a reexport #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

Replace arch-conditional c_char with a reexport #4205

merged 2 commits into from
Dec 17, 2024

Conversation

tgross35
Copy link
Contributor

For any platforms that have c_char within a cfg_if block, ensure they match the top-level arch definitions and reexport that to clean up code.

@tgross35
Ignore ordering style for c_char
c33744e
@tgross35
Replace arch-conditional c_char with a reexport
fead383 
For any platforms that have `c_char` within a `cfg_if` block, ensure
they match the top-level `arch` definitions and reexport that to clean
up code.
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

@tgross35: no appropriate reviewer found, use r? to override

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@tgross35 tgross35 added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch O-unix O-solarish O-redox and removed S-waiting-on-review O-unix O-solarish O-redox labels Dec 17, 2024
@tgross35 tgross35 enabled auto-merge December 17, 2024 21:52
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into rust-lang:main with commit 5f41b7a Dec 17, 2024
45 checks passed
@tgross35 tgross35 deleted the arch-c-char branch December 17, 2024 22:20
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 18, 2024
@tgross35
Ignore ordering style for c_char
0567b59 
(backport <rust-lang#4205>)
(cherry picked from commit c33744e)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 18, 2024
@tgross35
Replace arch-conditional c_char with a reexport
2ade12c 
For any platforms that have `c_char` within a `cfg_if` block, ensure
they match the top-level `arch` definitions and reexport that to clean
up code.

(backport <rust-lang#4205>)
(cherry picked from commit fead383)
@tgross35 tgross35 mentioned this pull request Dec 18, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O-redox O-solarish O-unix stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross35 @rustbot