Skip to content

Link to libraries when disabling use_std #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2016

Conversation

alexcrichton
Copy link
Member

This crate currently relies on libraries being linked to come from libstd, but
if use_std is disabled that's not true! In that case we need to pull in the
libraries ourselves.

Closes rust-lang/rust#32661

@rust-highfive
Copy link

@alexcrichton: no appropriate reviewer found, use r? to override

@alexcrichton
Copy link
Member Author

@bors: r+ 918e8b4

bors added a commit that referenced this pull request Apr 1, 2016
Link to libraries when disabling `use_std`

This crate currently relies on libraries being linked to come from libstd, but
if `use_std` is disabled that's not true! In that case we need to pull in the
libraries ourselves.

Closes rust-lang/rust#32661
@bors
Copy link
Contributor

bors commented Apr 1, 2016

⌛ Testing commit 918e8b4 with merge 51cc6cc...

@bors
Copy link
Contributor

bors commented Apr 1, 2016

💔 Test failed - travis

This crate currently relies on libraries being linked to come from libstd, but
if `use_std` is disabled that's not true! In that case we need to pull in the
libraries ourselves.

Closes rust-lang/rust#32661
@alexcrichton
Copy link
Member Author

@bors: r+ a28ec43

@bors
Copy link
Contributor

bors commented Apr 4, 2016

⌛ Testing commit a28ec43 with merge 2ded9ae...

bors added a commit that referenced this pull request Apr 4, 2016
Link to libraries when disabling `use_std`

This crate currently relies on libraries being linked to come from libstd, but
if `use_std` is disabled that's not true! In that case we need to pull in the
libraries ourselves.

Closes rust-lang/rust#32661
@bors
Copy link
Contributor

bors commented Apr 4, 2016

☀️ Test successful - status-appveyor, travis

@bors bors merged commit a28ec43 into rust-lang:master Apr 4, 2016
@alexcrichton alexcrichton deleted the fix-link branch September 6, 2016 20:53
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants