Deprecate XU_NGROUPS on DragonFly #2462
Conversation
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
|
It's not clear to me if the deprecation policy needs to be followed for tier 3 targets, or if this constant can be dropped from DragonFly immediately. There are likely some other constants which need to be removed to get the libc-test tests passing, so it'd be nice to have an official answer. |
|
I'd generally deprecate items first (and then remove them) regardless of the targets as we cannot see the complete number of users depending on it (yes, it's "generally", I'm fine with removing/changing something directly if it causes a regression or something like unfortunate thing). |
|
@bors r+ |
|
📌 Commit e6d308d has been approved by |
Deprecate XU_NGROUPS on DragonFly This constant was only ever defined on FreeBSD. https://github.com/freebsd/freebsd-src/blob/a7d137fcbcac7182d4fcdc97a46b10edc5c7041d/sys/sys/ucred.h https://github.com/DragonFlyBSD/DragonFlyBSD/blob/c2e500ae4c06466901674883b4593bd9c249cdc1/sys/sys/ucred.h
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
This constant was only ever defined on FreeBSD.
https://github.com/freebsd/freebsd-src/blob/a7d137fcbcac7182d4fcdc97a46b10edc5c7041d/sys/sys/ucred.h
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/c2e500ae4c06466901674883b4593bd9c249cdc1/sys/sys/ucred.h