Skip to content

Conversation

lambda
Copy link
Contributor

@lambda lambda commented Feb 1, 2016

According to POSIX, sysconf can take _SC_PAGESIZE or _SC_PAGE_SIZE,
which may be the same value. This constant was defined in "apple" as
equal to _SC_PAGESIZE, but not any of the other platforms.

Add definitions for _SC_PAGE_SIZE for all platforms which had
_SC_PAGESIZE defined. On all platforms but Android (Bionic), they are
the same value; on Android _SC_PAGE_SIZE has a different value.

@alexcrichton
Copy link
Member

Gah alas I merged #167 before I got to this one, and unfortunately unlike Rust we don't have @bors to auto-rebase everything. Could you rebase and re-push? I'll merge once the CI passes there as well.

According to POSIX, sysconf can take _SC_PAGESIZE or _SC_PAGE_SIZE,
which may be the same value.  This constant was define in "apple" as
equal to _SC_PAGESIZE, but not any of the other platforms.

Add definitions for _SC_PAGE_SIZE for all platforms which had
_SC_PAGESIZE defined. On all platforms but Android (Bionic), they are
the same value; on Android _SC_PAGE_SIZE has a different value.
@lambda
Copy link
Contributor Author

lambda commented Feb 1, 2016

Rebased

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android wat r u doin

alexcrichton added a commit that referenced this pull request Feb 1, 2016
Define _SC_PAGE_SIZE constants
@alexcrichton alexcrichton merged commit 026f4b3 into rust-lang:master Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants