Skip to content

Conversation

alexcrichton
Copy link
Member

This'll be used in libstd upstream, and this also enables wasi on CI!

Now that wasi is in nightlies, we can run it on PRs!
@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 7, 2019

@alexcrichton maybe it would be better to allow CI to fail for wasi for now, so that the other changes here can land. You can always fix CI in a subsequent PR.

Added recently and will be used in libstd!
@alexcrichton
Copy link
Member Author

Oh I think that's just a mistake in the container, the CI should be pretty reliable because all the relevant wasi pieces are pinned. If it becomes an issue though then it can of course be disabled

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 8, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 8, 2019

📌 Commit cc03101 has been approved by gnzlbg

bors added a commit that referenced this pull request Apr 8, 2019
 Add binding for new `__wasilibc_find_relpath` API

This'll be used in libstd upstream, and this also enables wasi on CI!
@bors
Copy link
Contributor

bors commented Apr 8, 2019

⌛ Testing commit cc03101 with merge 363ba93...

@bors
Copy link
Contributor

bors commented Apr 8, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 363ba93 to master...

@bors bors merged commit cc03101 into rust-lang:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants