This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Adding more details on local dev setup #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Mar 27, 2018
README.md
Outdated
Member
There was a problem hiding this comment.
Looks good. Could you add a warning that users should not make the OAuth token public (including checking it in to a public repo, and further including in the Git history even if it is later removed).
Collaborator
Author
There was a problem hiding this comment.
I added the following to below the config file example:
Do not check in this file or commit your OAuth token to a repository in any other way. It is a secret.
davidalber
force-pushed
the
more-dev-setup-instructions
branch
2 times, most recently
from
f530fc2 to
6520084
Compare
davidalber
force-pushed
the
more-dev-setup-instructions
branch
from
6520084 to
8d4d9f6
Compare
Member
|
Thanks for updating |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information on obtaining an OAuth token, setting up the config file, and that Highfive ignores comments from the integration user. Until the working branch is deleted, you can see the rendered README here.
This is a follow-up to #120.