add GlobError::into_error so that errors can be easily converted #66
Conversation
| @@ -61,6 +61,7 @@ | |||
| #![deny(missing_docs)] | |||
| #![cfg_attr(all(test, windows), feature(std_misc))] | |||
|
|
|||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
I thought I would throw this in as well.
There was a problem hiding this comment.
What imports cause these warning?
There was a problem hiding this comment.
it only affects the next statement, so use std::ascii::AsciiExt. This was introduced in recent rust versions
There was a problem hiding this comment.
Ah, yeah that makes sense then. :)
|
This is related to, but does not solve #64 (that is a separate issue related to using the library directly, this is for libraries that depend on this to be able to convert the types). |
| @@ -279,12 +280,18 @@ impl GlobError { | |||
| pub fn error(&self) -> &io::Error { | |||
| &self.error | |||
| } | |||
|
|
|||
| /// Consumes self, returning the _raw_ underlying `io::Error` | |||
| pub fn into_error(self) -> io::Error { | |||
There was a problem hiding this comment.
It seems a bit weird to have a into_error() method on a type that already is a Error - maybe something like into_io_error() to be more explicit?
Alternativly, if its clear in the API that this just wraps an io::Error, into_inner() might also be appropiate to follow the std conventions about wrapper types.
There was a problem hiding this comment.
I went with into_error() because the method directly above it (which returns io::Error) is called just error(). I do agree that I like into_io_error better, but should I also create an io_error() method and deprecate error()?
There was a problem hiding this comment.
I missed that there is precedent with the error() method. I guess then the name into_error() is the consistent choice.
For the
ergo_fscrate I would like to convertGlobErrorintoPathError. However I cannot without some performance penalty, since there is no way to get the originalio::Errorobject.