-
Notifications
You must be signed in to change notification settings - Fork 85
glob-tilde-expansion #149 #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BiswajitThakur
wants to merge
13
commits into
rust-lang:master
Choose a base branch
from
BiswajitThakur:glob-tilde-expansion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0531037
glob-tilde-expansion #149
BiswajitThakur d047d76
fix: comment
BiswajitThakur 8641923
Update src/utils.rs
BiswajitThakur ddeeec6
Update src/utils.rs
BiswajitThakur fabeb16
refactor: remove unnecessary fn call
BiswajitThakur 3e8799b
Update src/utils.rs
BiswajitThakur e535db6
Update src/utils.rs
BiswajitThakur d5dd7a8
Apply suggestion from @reneleonhardt
BiswajitThakur be3ae79
removed-glob_tilde_expansion-method-from-MatcherOption
BiswajitThakur 498392c
.
BiswajitThakur 63f96b3
Update src/utils.rs
BiswajitThakur 0cb91c6
return error if ~ followed by not / or not user name or failed to det…
BiswajitThakur 589787a
fix: err msg
BiswajitThakur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#[inline(always)] | ||
pub(crate) fn get_home_dir() -> Option<String> { | ||
#[allow(deprecated)] | ||
std::env::home_dir().and_then(|v| v.to_str().map(String::from)) | ||
BiswajitThakur marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// This function is required when `glob_tilde_expansion` field of `glob::MatchOptions` is | ||
// set `true` and pattern starts with `~` followed by any char expect `/` | ||
pub(crate) fn get_user_name() -> Option<String> { | ||
let varname = if cfg!(windows) { "USERNAME" } else { "USER" }; | ||
std::env::var(varname).ok() | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intent of this branch? AFAIK
~foo
without the path shouldn't be a valid patternThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~
followed by user name then~
and username are substituted by the home directory of that user.~
followed by not username or not/
or the home directory cannot be determined as an error. we have to add a another field toMatchOptions
. if the fiend is settrue
the it will be return error. if the field setfalse
, it ignore it.(could i add an extra field to the
MatcherOptiond
?)https://man7.org/linux/man-pages/man3/glob.3.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that in the glob manpage, thanks.
I think we should defer that part, and error if there is
~
not followed by/
. Checking the env isn't always accurate: it needsgetpwuid_r
on Unix andGetUserProfileDirectoryA
on Windows, which is more complexity than this crate should add.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, i will update it.