Skip to content

Change SinkExt::send_all to take stream by value #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

Change SinkExt::send_all to take stream by value #2340

merged 1 commit into from
Mar 20, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 13, 2021 •
edited
Loading

Closes #2214

This PR is marked as a draft because based on #2335.
See the second commit for actual changes in this PR.

@taiki-e taiki-e added the A-sink Area: futures::sink label Feb 13, 2021
@taiki-e taiki-e added this to the futures-0.4 milestone Feb 13, 2021
@taiki-e taiki-e mentioned this pull request Feb 13, 2021
Merged
@taiki-e taiki-e marked this pull request as ready for review February 26, 2021 02:54
@taiki-e taiki-e merged commit e093a0e into rust-lang:master Mar 20, 2021
@taiki-e taiki-e deleted the 0.4-sink-send_all branch March 20, 2021 08:32
@taiki-e taiki-e changed the title 0.4: Change SinkExt::send_all to take stream by value Change SinkExt::send_all to take stream by value Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-sink Area: futures::sink breaking change
Projects
None yet
Milestone
futures-0.4, futures-core-1.0
Development

Successfully merging this pull request may close these issues.

Should SinkExt::send_all take stream by value
1 participant
@taiki-e