Task docs #1236
Merged
Task docs #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I updated the URL. I still believe this is a net win and the question still gets asked in the Tokio gitter. |
src/task_impl/mod.rs
Outdated
| /// | ||
| /// In this case, the idea is that whenever a `start_send` is called on one of | ||
| /// the channel's send handles, if the channel is at capacity, the current task | ||
| /// is stored in a `TaskSet`. Then, when capacity is available, a task is |
Contributor
There was a problem hiding this comment.
is TaskSet an actual type?
Contributor
Author
There was a problem hiding this comment.
It is a hypothetical.
Member
There was a problem hiding this comment.
Perhaps "a task set" (like you use elsewhere) would be clearer that TaskSet isn't an actual type?
Contributor
|
Looks good |
Contributor
|
And about the discussion about whether to put such an explanation in the docs: IMO if people are asking this a lot, then it's appropriate to put such an explanation in the docs for the type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to clarify the problem with using a set structure to store tasks.
This question has come up a bunch; e.g. #670.
Continuation of #689 since I no longer have access to that branch.