Vendor FontAwesome and Pure-CSS #981
Conversation
jyn514
added
the
S-waiting-on-review
Kixiron
force-pushed
the
vending-machine
branch
from
dd87856 to
6964fbf
Compare
Kixiron
force-pushed
the
vending-machine
branch
from
6964fbf to
34af784
Compare
|
You also need to update the dockerfile. |
| // Variables | ||
| // -------------------------- | ||
|
|
||
| $fa-font-path: "../-/static" !default; |
There was a problem hiding this comment.
Instead of changing the path in the vendored file (which would override it when we update FA), could you set the variable in our own base.scss?
There was a problem hiding this comment.
This was the recommendation in fontawesome's docs, but I can do whatever
There was a problem hiding this comment.
Why are they recommending that :/
There was a problem hiding this comment.
I have no idea to be perfectly honest
There was a problem hiding this comment.
Note that this will be fixed whenever we can use scss modules, at that time we can use something along these lines
@use "fontawesome" with (
$fa-font-path: "../-/static"
);
// For more info see https://sass-lang.com/documentation/at-rules/use#configurationModules are nice for other reasons as well, they allow namespacing and explicit access to external variables, mixins and rules
|
If the goal is getting docs.rs up and running in China as soon as possible, I'm happy to not block on my comments and merge, if a followup PR is made addressing them. |
|
I'm so sorry, I've been taking a breather the last few days but I'll get right on this |
Co-authored-by: Joshua Nelson <[email protected]>
… and made fetching content from vendored directories automatic
Kixiron
force-pushed
the
vending-machine
branch
from
cbe38c1 to
30ae906
Compare
Kixiron
force-pushed
the
vending-machine
branch
from
e07246e to
59e856f
Compare
| // MimeGuess misses a lot of the file types we need, so there's a small wrapper | ||
| // around it |
There was a problem hiding this comment.
Can we upstream this patch? I don't want to have to special case things if I can at all help it.
There was a problem hiding this comment.
I'm going to guess not since there's lots of open issues & prs for exactly this with no response. It shouldn't really be a huge deal since there's not very many exceptions
This was never addressed ... it would be great to be able to replicate the changes. Right now it just looks like an opaque 8k line blob. |
|
This broke fonts and has been reverted in production.
Looks like there was an extra |
|
It's because of |
Vendor all of our CSS, allows more users to access our site while simultaneously making less requests to load our page
Since we're using SASS for everything, this also allows for us to serve one single CSS file instead of the previous 4+
Closes #979 and #921.